chore: use opam to simplify makefile #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backwards compatibility summary: |
mjambon
approved these changes
Mar 5, 2025
mmcqd
pushed a commit
that referenced
this pull request
Mar 11, 2025
Let's install check-jsonschema via depexts! See semgrep/semgrep-proprietary#3273 for more context - [X] I ran `make setup && make` to update the generated code after editing a `.atd` file (TODO: have a CI check) - [X] I made sure we're still backward compatible with old versions of the CLI. For example, the Semgrep backend need to still be able to *consume* data generated by Semgrep 1.50.0. See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades Note that the types related to the semgrep-core JSON output or the semgrep-core RPC do not need to be backward compatible!
aryx
reviewed
Mar 18, 2025
| ["check-jsonschema"] {os-distribution = "alpine"} | ||
| ["check-jsonschema"] {os = "macos" & os-distribution = "homebrew"} | ||
| ["check-jsonschema"] {os = "macos" & os-distribution = "macports"} | ||
| ["check-jsonschema"] {os = "win32" & os-distribution = "macports"} |
There was a problem hiding this comment.
there is macports on win32??
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Mar 18, 2025
…3273) Right now we aren't installing any of the deps needed to build/test semgrep-interfaces, which is needed for the core-e2e-test target. This PR changes that so we install the needed deps to run those tests (check-jsonschema). It also installs the deps needed to generate the interfaces in the first place, which means in the future we could easily make building the interfaces a dune rule. Please approve semgrep/semgrep-interfaces#361 first so we can set the submodule ref to a develop commit. ## Test plan check-semgrep-oss passes synced from Pro b554c51ff7b354b6040379bfee051169c890f0de
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Mar 19, 2025
…3273) Right now we aren't installing any of the deps needed to build/test semgrep-interfaces, which is needed for the core-e2e-test target. This PR changes that so we install the needed deps to run those tests (check-jsonschema). It also installs the deps needed to generate the interfaces in the first place, which means in the future we could easily make building the interfaces a dune rule. Please approve semgrep/semgrep-interfaces#361 first so we can set the submodule ref to a develop commit. ## Test plan check-semgrep-oss passes synced from Pro b554c51ff7b354b6040379bfee051169c890f0de
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Mar 19, 2025
…3273) Right now we aren't installing any of the deps needed to build/test semgrep-interfaces, which is needed for the core-e2e-test target. This PR changes that so we install the needed deps to run those tests (check-jsonschema). It also installs the deps needed to generate the interfaces in the first place, which means in the future we could easily make building the interfaces a dune rule. Please approve semgrep/semgrep-interfaces#361 first so we can set the submodule ref to a develop commit. ## Test plan check-semgrep-oss passes synced from Pro b554c51ff7b354b6040379bfee051169c890f0de
ajbt200128
added a commit
to semgrep/semgrep
that referenced
this pull request
Mar 19, 2025
…3273) Right now we aren't installing any of the deps needed to build/test semgrep-interfaces, which is needed for the core-e2e-test target. This PR changes that so we install the needed deps to run those tests (check-jsonschema). It also installs the deps needed to generate the interfaces in the first place, which means in the future we could easily make building the interfaces a dune rule. Please approve semgrep/semgrep-interfaces#361 first so we can set the submodule ref to a develop commit. ## Test plan check-semgrep-oss passes synced from Pro b554c51ff7b354b6040379bfee051169c890f0de
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's install check-jsonschema via depexts!
See https://github.com/semgrep/semgrep-proprietary/pull/3273 for more context
make setup && maketo update the generated code after editing a.atdfile (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data
generated by Semgrep 1.50.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
Note that the types related to the semgrep-core JSON output or the
semgrep-core RPC do not need to be backward compatible!