Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restructure: crate #6

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

restructure: crate #6

wants to merge 6 commits into from

Conversation

brech1
Copy link
Collaborator

@brech1 brech1 commented Apr 1, 2025

Description

This PR introduces a restructuring of the semaphore-rs crate.

Changes

  • Updates to Rust 2024 edition and arkworks cryptographic libraries
  • Adds a Baby Jubjub curve implementation adhering to EIP-2494 specs
  • Adds general error handling with specific error types
  • Implements identity and group modules
  • Adds integration tests for identity operations

Related Issue(s)

Checklist

  • I have read and understand the contributor guidelines and code of conduct.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run cargo fmt without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

vivianjeng
vivianjeng reviewed Apr 2, 2025
View reviewed changes
src/lib.rs Outdated
Comment on lines 3 to 5
pub mod proof;

pub mod utils;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you keep these two files,
we still need this prover structure

@brech1 brech1 force-pushed the restructure/crate branch from d720cd7 to 3a736b5 Compare April 2, 2025 02:44
@KimiWu123 KimiWu123 mentioned this pull request Apr 9, 2025
Draft
@KimiWu123 KimiWu123 requested a review from vplasencia April 10, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivianjeng vivianjeng vivianjeng left review comments

@vplasencia vplasencia Awaiting requested review from vplasencia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Identity implementation
2 participants
@brech1 @vivianjeng