Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Swift 5.10 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mackoj
Copy link

@mackoj mackoj commented Sep 4, 2024

The main issue is that SwiftPM depends on TSCBasic but declares types that are the same as those in TSCBasic, like AbsolutePath, which creates conflicts.

The fix is to add a converter file that contain helpers for the type conversion.

This PR is a prototype.

@bsneed
Copy link
Collaborator

bsneed commented Sep 8, 2024

Thanks @mackoj ! I'm curious about the whitespace changes. Was stuff out of alignment? I'll probably add something to format the code after I merge this.

@mackoj
Copy link
Author

mackoj commented Sep 8, 2024

The white space might be due to the setting of my Xcode configuration because I use two space sorry.

@Hugo-Persson
Copy link

What is the status of this PR? It would really help me in my project

@mackoj mackoj marked this pull request as ready for review September 24, 2024 07:15
@mackoj
Copy link
Author

mackoj commented Sep 24, 2024

Sorry @Hugo-Persson I did forget about this.

@bsneed
Copy link
Collaborator

bsneed commented Sep 26, 2024

Heya everyone; I looked into merging this again today. There's some issues w/ the PR besides the spaces; in that it moves the tooling all the way up to Swift 5.10 and ends up breaking the backward compatibility setup that's in the package. I managed to get that fixed, but the divergence/duplication between Basics in SwiftPM and TSCBasic in swift-tools-support-core is pretty gnarly.

I'm gonna take a look at how best to address some of this stuff, not quite sure just yet.

@kaeawc
Copy link

kaeawc commented Oct 21, 2024

I've been able to use this against a Swift 6 codebase and in XCode 16, so far without issue. Are there any gotchas we should look out for?

@SubvertDev
Copy link

@kaeawc did you do any modifications to this PR in order to run it on Swift 6? It's working only in 5.10 mode for me

@kaeawc
Copy link

kaeawc commented Nov 4, 2024

@SubvertDev my mistake for being new to the whole XCFramework bundling - I was mistaken and didn't realize the lack of Swift 5.10 support meant the publisher, not the consumer.

@SubvertDev
Copy link

@kaeawc gotcha, no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants