Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible fix of #198 #199

Closed
wants to merge 4 commits into from
Closed

possible fix of #198 #199

wants to merge 4 commits into from

Conversation

braindevices
Copy link

@braindevices braindevices commented Aug 6, 2017 •
edited
Loading

  • I removed the asn.ASNOrigin class and move all functions to ASNOrigin module.
  • I also moved the get_asn_origin_whois and get_http_raw from net.Net to ASNOrigin module. Thus we do not need the strange Net object as __init__() argument.
  • I created dummy entry points to make it roughly compatible to old projects based on ASNOrigin class.
  • Several test cases will fail due to change ASNOrigin from class to module. The timeout value stored in Net object has no effect.

@braindevices braindevices mentioned this pull request Aug 6, 2017
Open
@secynic
Copy link
Owner

secynic commented Aug 25, 2017

See #198 for details on PR closure

@secynic secynic closed this Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braindevices @secynic