Rework Folder Structure #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sar_* and phasar_llvm_*
…lvm to phasar-cli
2 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
MMory
reviewed
Feb 9, 2023
| } | ||
| return OS; | ||
| // Microsoft ABI is a bit more complicated... | ||
| return Name != llvm::demangle(Name.str()); | ||
| } | ||
|
|
||
| bool StringIDLess::operator()(const std::string &Lhs, |
There was a problem hiding this comment.
please make a seperate PR for this change, this is unrelated to folder structure and too complex just to sneak it in
There was a problem hiding this comment.
Agreed, and tag me in the PR please I can add the stuff regarding the Swift ABI and mangling :)
Here we want to essentially check for "begins with '$s'".
fabianbs96
requested review from
janniclas,
pdschubert and
vulder
as code owners
vulder
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
LGTM
Currently, with a few tweaks I could get this PR to work.
What I needed to change is shown here IntegrationPR maybe some of these should be added to the dev suggestions part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While PhASAR has grown over the years, the initial folder structore does no longer correspond to the semantics.
For example, non-LLVM stuff is placed within PhasarLLVM, etc.
This PR moves files between folders in order to re-sync file- and folder- semantics