Fix in KNXnet/IP layer (KNX addresses handling) #4663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Could you fix the flake8 issues at https://github.com/secdev/scapy/actions/runs/13262979518/job/37023594039?pr=4663 ? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4663 +/- ##
==========================================
+ Coverage 81.55% 82.14% +0.59%
==========================================
Files 359 361 +2
Lines 86557 86820 +263
==========================================
+ Hits 70592 71321 +729
+ Misses 15965 15499 -466
🚀 New features to boost your workflow:
|
|
Done, it should be ok now! Sorry for the delay. |
gpotter2
requested changes
Mar 17, 2025
Comment on lines
-200
to
+207
| if self.structure_length is None: | ||
| p = struct.pack("!B", len(p)) + p[1:] | ||
| p = (len(p)).to_bytes(1, byteorder='big') + p[1:] |
There was a problem hiding this comment.
Why those changes?
I think I disagree.
Comment on lines
-253
to
+256
| if self.structure_length is None: | ||
| p = struct.pack("!B", len(p)) + p[1:] | ||
| p = (len(p)).to_bytes(1, byteorder='big') + p[1:] |
Comment on lines
-287
to
+288
| if self.structure_length is None: | ||
| p = struct.pack("!B", len(p)) + p[1:] | ||
| p = (len(p)).to_bytes(1, byteorder='big') + p[1:] |
There was a problem hiding this comment.
Same (and in all following post_build)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few changes to the KNXnet/IP layer, last updated in 2021:
I made the PR mainly to fix issues when building packets containing individual address (format 1.1.1) or group address (format 1/1/1) fields. The layer only supported either individual address or group address in a field, but some fields (for instance, in cEMI blocks) can take both formats. For instance, the code below used to raise a ValueError and is now valid.