Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MDOPEN #31

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Support MDOPEN #31

merged 4 commits into from
Aug 16, 2024

Conversation

CsBigDataHub
Copy link
Contributor

Hello @seagle0128,

I tried to incorporate mdopen top grip-mode.
However I am not able to incorporate webkit-preview with mdopen. I was only open the preview on a default browser.
Feel free to modify this pr.

Thanks

@seagle0128
Copy link
Owner

Can we reuse grip-binary-path and add grip-args to simplify the process?

@CsBigDataHub
Copy link
Contributor Author

Can we reuse grip-binary-path and add grip-args to simplify the process?

Maybe, but I wanted to keep it separate. What would happen if we have both grip and mdopen in $PATH?

@seagle0128
Copy link
Owner

Then move forward, please.

@CsBigDataHub CsBigDataHub marked this pull request as ready for review August 16, 2024 12:49
@seagle0128 seagle0128 merged commit ce282ff into seagle0128:master Aug 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants