Add py3.12 #95
Add py3.12 #95
Conversation
|
Task linked: CU-86ayu71by DeepEcho - Support Python 3.12 #85 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 79.39% 79.12% -0.28%
==========================================
Files 7 7
Lines 728 728
==========================================
- Hits 578 576 -2
- Misses 150 152 +2 ☔ View full report in Codecov by Sentry. |
fealho
force-pushed
the
issue-85-py12
branch
2 times, most recently
from
9fe73a1 to
7f52361
Compare
| @@ -54,7 +55,7 @@ dev = [ | |||
| 'setuptools<49.2', | |||
| 'bump-my-version>=0.18.3,<1', | |||
| 'pip>=9.0.1', | |||
| 'watchdog>=0.8.3,<0.11', | |||
| 'watchdog>=1.0.1,<5', | |||
There was a problem hiding this comment.
Python 3.12 has removed support for the imp library, which watchdog uses up to version 0.10.7.
fealho
force-pushed
the
issue-85-py12
branch
3 times, most recently
from
68dc7aa to
f729e51
Compare
| "torch>=2.0.0;python_version>='3.11'", | ||
| 'tqdm>=4.15,<5', | ||
| "torch>=2.0.0;python_version>='3.11' and python_version<'3.12'", | ||
| "torch>=2.2.0;python_version>='3.12'", |
There was a problem hiding this comment.
Because we updated numpy's version we get this: ERROR: Could not find a version that satisfies the requirement torch==2.1.0 (from versions: 2.2.0, 2.2.1), so we need to increase torch's version as well to pass the minimum tests.
| readme = 'README.md' | ||
| dependencies = [ | ||
| "numpy>=1.20.0,<2;python_version<'3.10'", | ||
| "numpy>=1.23.3,<2;python_version>='3.10'", | ||
| "numpy>=1.23.3,<2;python_version>='3.10' and python_version<'3.12'", | ||
| "numpy>=1.26.0,<2;python_version>='3.12'", |
There was a problem hiding this comment.
Versions before numpy>=1.26.0 run into ModuleNotFoundError: No module named 'distutils'.
There was a problem hiding this comment.
Yeah it seems like numpy doesn't support python 3.12 on versions before 1.26 on PyPi either
| 'tqdm>=4.15,<5', | ||
| "torch>=2.0.0;python_version>='3.11' and python_version<'3.12'", | ||
| "torch>=2.2.0;python_version>='3.12'", | ||
| 'tqdm>=4.29,<5', |
There was a problem hiding this comment.
Versions older than 4.29 run into this issue for the minimum tests.
fealho
requested review from
amontanez24 and
pvk-developer
and removed request for
a team
| readme = 'README.md' | ||
| dependencies = [ | ||
| "numpy>=1.20.0,<2;python_version<'3.10'", | ||
| "numpy>=1.23.3,<2;python_version>='3.10'", | ||
| "numpy>=1.23.3,<2;python_version>='3.10' and python_version<'3.12'", | ||
| "numpy>=1.26.0,<2;python_version>='3.12'", |
There was a problem hiding this comment.
Yeah it seems like numpy doesn't support python 3.12 on versions before 1.26 on PyPi either
CU-86ayu71by, Resolve #85.