Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goreleaser: Update latest tag on docker hub to actual latest #4307

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lsfreitas
Copy link

update latest to actual latest tag available by running docker pull scylladb/scylla-manager:latest

Fixes:#4250

update latest to actual latest tag available by running docker pull scylladb/scylla-manager:latest

Fixes:scylladb#4250
@lsfreitas
Copy link
Author

@Annamikhlin @yaronkaikov this ain't tested yet since I'm having issues running "make snapshot" on my machine but you can start having a look. Setting it to draft until I fully test it

@lsfreitas lsfreitas marked this pull request as draft March 18, 2025 15:23
@lsfreitas lsfreitas self-assigned this Mar 18, 2025
@yaronkaikov
Copy link
Collaborator

@lsfreitas The change in general looks good (and working), but it's incomplete. The way it's implemented means that every time we run build it will update the latest for docker image. When this change will be part of multiple release or even one release and master, it will override the latest every run. We need a way to run this part only of latestRelease flag is true (we don't have this flag, but we should created it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants