Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize the code base #6

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Modernize the code base #6

merged 4 commits into from
Feb 4, 2025

Conversation

Gallaecio
Copy link
Contributor

@Gallaecio Gallaecio commented Jan 27, 2025

To do:

@Gallaecio Gallaecio marked this pull request as ready for review February 3, 2025 14:43
@Gallaecio Gallaecio marked this pull request as draft February 3, 2025 14:43
@Gallaecio
Copy link
Contributor Author

@zvin Hey, I see yours is the only account in https://pypi.org/project/scrapy-feedexporter-sftp/. Could you add scrapy as well?

@zvin
Copy link
Collaborator

zvin commented Feb 4, 2025

@Gallaecio I completely forgot about this repo :)
Invitation sent!

@zvin
Copy link
Collaborator

zvin commented Feb 4, 2025

Should I invite ScrapyPlugins as well @Gallaecio ?

@Gallaecio
Copy link
Contributor Author

Gallaecio commented Feb 4, 2025

Thank you! All is set up now.

Hmm… It seems the scrapy account does not have enough permissions to set up trusted publishing, I cannot access here.

@zvin
Copy link
Collaborator

zvin commented Feb 4, 2025

There's no permission settings on pypi, you can only be a maintainer or an owner.
I've made scrapy an owner now @Gallaecio

@Gallaecio
Copy link
Contributor Author

Thank you. Trusted publishing from GitHub is now configured.

@Gallaecio Gallaecio marked this pull request as ready for review February 4, 2025 13:40
@Gallaecio Gallaecio requested review from kmike and wRAR February 4, 2025 13:40
Copy link
Contributor

@wRAR wRAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Gallaecio Gallaecio merged commit 598cd98 into master Feb 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants