Added details of the OSU SubCritical Assembly and code specifics. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should resolve #1 |
munkm
reviewed
Mar 6, 2025
| - **Location:** | ||
| Centrally located on the graphite floor at coordinates (75, -15, 75) with a raii of 2 cm within the reactor framework. | ||
|
|
||
|
|
There was a problem hiding this comment.
I know that we don't have explicit references for this model, but I think it would be good to say where you got the information to construct it. Perhaps "we would like to thank Dr. Reese for providing information on the locations of fuel elements used to construct this model".
README.md
Outdated
|
|
||
| - **Graphite Bricks:** Serve as both structural support and neutron moderator. | ||
| - **UO_2 Fuel:** Annular fuel rods with natural uranium enrichment (0.072% U-235) and aluminum cladding. | ||
| - **Concrete Reflector:** Enhances neutron economy by reflecting neutrons back into the assembly. |
There was a problem hiding this comment.
"Reflector" will likely be interpreted by readers as surrounding the reactor core. Perhaps you can say "concrete structural material" and specify that this is the floor and wall next to the assembly, and state that it is also a reflector.
There was a problem hiding this comment.
Understood and edited to reflect as such.
Comment on lines
+17
to
+24
| - **Type:** Annular rods with aluminum cladding. | ||
| - **Enrichment:** Natural uranium (0.072% U-235). | ||
| - **Dimensions:** | ||
| - **Fuel Length in z-direction:** 45 cm | ||
| - **Innermost Air Hole Radii:** 0.46 cm | ||
| - **Clad Inner Radii:** 0.61875 cm | ||
| - **Radii of the UO_2 Fuel:** 1.76125 cm | ||
| - **Radii of Outermost Clad:** 1.92 cm |
There was a problem hiding this comment.
This is great. I know you have the locations of the centerpoints of the fuel rods, but do you have a notion of the pitch that separates them?
There was a problem hiding this comment.
Yes, I have updated the README to add that detail; the pitch is 15 cm.
README.md
Outdated
| - **Height in y-direction:** 15 cm | ||
| - **Width in z-direction:** 15 cm | ||
| - **Fuel Arrangement:** | ||
| Each brick features a central hole for fuel placement that is the same radii as the outermost cladding of the fuel. Along the z-axis of the brick, three UO_2 fuel rods are inserted. The combined length of these rods is 135 cm, with an additional 15 cm gap filled by air. |
There was a problem hiding this comment.
Say that the rods are inserted "end to end" so it is clear that they are in a single hole and not three separate holes in a concrete block.
This description of the brick arrangement I'm having trouble visualizing. are there 10 or so bricks stacked in the z-direction to make a 150cm long hole for the rods?
There was a problem hiding this comment.
Noted and edited.
I have reworded the description and hopefully described the arragement better.
…ng has been split to another script called Analysis.ipynb.
Added a section on running the actual model script and the analysis script. Added a section on documentation that links to the official OpenMC documentation website. Added acknowledgements for Dr. Steve Reese for providing the necessary information to build the model.
Added more detail on describing the graphite brick arrangement to make it clearer to the reader.
README.md
Outdated
| This repository contains an OpenMC model of the subcritical assembly at Oregon State University's Radiation Center. The assembly is composed of graphite bricks, UO_2 fuel rods, a concrete reflector, and a plutonium–beryllium neutron source. | ||
|
|
||
| ## Running the Python Script | ||
| - Running the RadCenterSubcriticalAssemblyOUS.ipynb will require OpenMC to be installed correctly on your computer. When running the script, look at the model.run command at the very end of the script; currently, it is being multithredded to 20 threads. Change this number to what ever you feel is necessary as long as you have enough threads in your CPU. To see how many CPU threads you have, look at Task Manager and click on the Performance Tab, there you will see on the bottom-left a list of technical specifications on your CPU, look to Logical Processors, that will be the number of threads you have. |
There was a problem hiding this comment.
Suggested change
| - Running the RadCenterSubcriticalAssemblyOUS.ipynb will require OpenMC to be installed correctly on your computer. When running the script, look at the model.run command at the very end of the script; currently, it is being multithredded to 20 threads. Change this number to what ever you feel is necessary as long as you have enough threads in your CPU. To see how many CPU threads you have, look at Task Manager and click on the Performance Tab, there you will see on the bottom-left a list of technical specifications on your CPU, look to Logical Processors, that will be the number of threads you have. | |
| - Running the RadCenterSubcriticalAssemblyOSU.ipynb will require OpenMC to be installed correctly on your computer. When running the script, look at the model.run command at the very end of the script; currently, it is being multithreaded to 20 threads. Change this number to whatever you feel is necessary as long as you have enough threads in your CPU. To see how many CPU threads you have, look at Task Manager and click on the Performance Tab, there you will see on the bottom-left a list of technical specifications on your CPU, look to Logical Processors, that will be the number of threads you have. |
README.md
Outdated
| ## Running the Python Script | ||
| - Running the RadCenterSubcriticalAssemblyOUS.ipynb will require OpenMC to be installed correctly on your computer. When running the script, look at the model.run command at the very end of the script; currently, it is being multithredded to 20 threads. Change this number to what ever you feel is necessary as long as you have enough threads in your CPU. To see how many CPU threads you have, look at Task Manager and click on the Performance Tab, there you will see on the bottom-left a list of technical specifications on your CPU, look to Logical Processors, that will be the number of threads you have. | ||
| - Take note as well to settings.particles and mesh.dimension, these values can be adjusted by the user as needed. Currently, the code will be very demanding on 20 cores due to the high values and will take a long time to compile. | ||
| - To run any analysis on the Analysis.ipynb script, make sure the outputs from the RadCenterSubcriticalAssemblyOUS.ipynb such as the tallies.xml, summary.xml, and the statepoint file are placed in the analysis folder. The script will not run at all if they are not present. |
There was a problem hiding this comment.
Suggested change
| - To run any analysis on the Analysis.ipynb script, make sure the outputs from the RadCenterSubcriticalAssemblyOUS.ipynb such as the tallies.xml, summary.xml, and the statepoint file are placed in the analysis folder. The script will not run at all if they are not present. | |
| - To run any analysis on the Analysis.ipynb script, make sure the outputs from the RadCenterSubcriticalAssemblyOSU.ipynb such as the tallies.xml, summary.xml, and the statepoint file are placed in the analysis folder. The script will not run at all if they are not present. |
README.md
Outdated
| - Running the RadCenterSubcriticalAssemblyOUS.ipynb will require OpenMC to be installed correctly on your computer. When running the script, look at the model.run command at the very end of the script; currently, it is being multithredded to 20 threads. Change this number to what ever you feel is necessary as long as you have enough threads in your CPU. To see how many CPU threads you have, look at Task Manager and click on the Performance Tab, there you will see on the bottom-left a list of technical specifications on your CPU, look to Logical Processors, that will be the number of threads you have. | ||
| - Take note as well to settings.particles and mesh.dimension, these values can be adjusted by the user as needed. Currently, the code will be very demanding on 20 cores due to the high values and will take a long time to compile. | ||
| - To run any analysis on the Analysis.ipynb script, make sure the outputs from the RadCenterSubcriticalAssemblyOUS.ipynb such as the tallies.xml, summary.xml, and the statepoint file are placed in the analysis folder. The script will not run at all if they are not present. | ||
| - If you change any parameters on the RadCenterSubcriticalAssemblyOUS.ipynb such as mesh dimension size, or the number of batches, some parameters on the Analysis.ipynb will need to be changed as a result to match. Running the script will tell you what you need to change. |
There was a problem hiding this comment.
Suggested change
| - If you change any parameters on the RadCenterSubcriticalAssemblyOUS.ipynb such as mesh dimension size, or the number of batches, some parameters on the Analysis.ipynb will need to be changed as a result to match. Running the script will tell you what you need to change. | |
| - If you change any parameters on the RadCenterSubcriticalAssemblyOSU.ipynb such as mesh dimension size, or the number of batches, some parameters on the Analysis.ipynb will need to be changed as a result to match. Running the script will tell you what you need to change. |
Updated the README to fix grammar errors and ran the whole md file through Microsoft Word to check for any other grammar mistakes that have been made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new branch to place the actual model of the subcritical assembly.