Move $HOME env variable outside web server's Document root #454
+38
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
phracek
requested changes
Jul 30, 2024
|
[test-all] |
phracek
reviewed
Aug 1, 2024
Pull Request validationFailed🔴 Failed or pending statuses - Success🟢 Review - Reviewed by undefined |
|
[test-all] |
Testing Farm results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overwrite $HOME env variable for all supported versions. Default $HOME is directed inside the web server's Document root, which means that applications that save potentially private data to $HOME (e.g. bash's histfile) will save them into a folder accessible outside the container via the web server. This means there is a possibility of leaking the data.
This does not occur in all cases, namely bash won't create a histfile at all, when user sets a different user via
--user=argument inpodman runcommand, as in that case bash doesn't have a permission to write into the $HOME.Fixes: #255