Add ROI histograms #303
Merged
Add ROI histograms #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was omitted previously since RollingDetectorView did not support non-consecutive detector numbers. Since we use scipp.group now this limitation was removed.
nvaytet
reviewed
Feb 6, 2025
| content.data = sc.ones( | ||
| dims=content.dims, shape=content.shape, dtype='float32', unit='counts' | ||
| ) | ||
| data.data = sc.bins(**constituents) |
There was a problem hiding this comment.
Can the _bins_no_validate be used here for extra performance gain?
There was a problem hiding this comment.
Yes, thanks, fixed now!
nvaytet
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is mainly about the
detector_dataservice, even though I have made a small dashboard addition so it can be tested/demonstrated. This is not meant to be usable, in particular there will/should be per-view controls. The config mechanism will also need updating for that.Depends on a release of scipp/essreduce#173.
Fixes #300 (in first approximation).