Code

2. [MRG] Bilinear similarity#329

Code

Open

mvargas33 wants to merge 65 commits intoscikit-learn-contrib:masterscikit-learn-contrib/metric-learn:masterfrom mvargas33:feat-bilinearmvargas33/metric-learn:feat-bilinearCopy head branch name to clipboard

+1,086-343

Commits

Commits on Oct 4, 2021

• Remove 3.9 from compatibility

  

  mvargas33

  authored and

  mvargas33

  committed
  4b7cdec

  Copy full SHA for 4b7cdec

• FIrst draft of bilinear mixin

  

  mvargas33

  authored and

  mvargas33

  committed
  0147c0c

  Copy full SHA for 0147c0c

• Fix score_pairs

  

  mvargas33

  authored and

  mvargas33

  committed
  ec09f59

  Copy full SHA for ec09f59

• Two implementations for score_pairs

  

  mvargas33

  authored and

  mvargas33

  committed
  ec49397

  Copy full SHA for ec49397

• Generalized toy tests

  

  mvargas33

  authored and

  mvargas33

  committed
  2f3c3e1

  Copy full SHA for 2f3c3e1

• Handmade tests incorporated

  

  mvargas33

  authored and

  mvargas33

  committed
  c21d283

  Copy full SHA for c21d283

• Fix identation for bilinear

  

  mvargas33

  committed
  dbe2a7a

  Copy full SHA for dbe2a7a

• Add performance test to choose between two methods for bilinear calc

  

  mvargas33

  committed
  ee5c5ee

  Copy full SHA for ee5c5ee

• Found an efficient way to compute Bilinear Sim for n pairs

  

  mvargas33

  committed
  9a10e06

  Copy full SHA for 9a10e06

• Update method's descriptions

  

  mvargas33

  committed
  b1edc46

  Copy full SHA for b1edc46

• Following the correct testing structure

  

  mvargas33

  committed
  ae562e6

  Copy full SHA for ae562e6

• Fix identation

  

  mvargas33

  committed
  7ebc026

  Copy full SHA for 7ebc026

• Add more tests. Fix 4 to 2 identation

  

  mvargas33

  committed
  1d752f7

  Copy full SHA for 1d752f7

• Minor flake8 fix

  

  mvargas33

  committed
  45c9b97

  Copy full SHA for 45c9b97

• Commented each test

  

  mvargas33

  committed
  407f910

  Copy full SHA for 407f910

• All tests have been generalized

  

  mvargas33

  committed
  80c9085

  Copy full SHA for 80c9085

• Fix flake8 identation

  

  mvargas33

  committed
  90ac550

  Copy full SHA for 90ac550

• Minor details

  

  mvargas33

  committed
  68eeda9

  Copy full SHA for 68eeda9

• Remove 3.9 from compatibility

  

  mvargas33

  authored and

  mvargas33

  committed
  c47797c

  Copy full SHA for c47797c

• First draft of refactoring BaseMetricLearner and Mahalanobis Learner

  

  mvargas33

  committed
  e07b11a

  Copy full SHA for e07b11a

Commits on Oct 6, 2021

• Avoid warning related to score_pairs deprecation in tests of pair_calibraiton

  

  mvargas33

  committed
  8210acd

  Copy full SHA for 8210acd

• Minor fix

  

  mvargas33

  committed
  11b5df6

  Copy full SHA for 11b5df6

• Replaced score_pairs with pair_distance in tests

  

  mvargas33

  committed
  06b7131

  Copy full SHA for 06b7131

• Replace score_pairs with pair_distance inb docs.

  

  mvargas33

  committed
  d5cb8b4

  Copy full SHA for d5cb8b4

Commits on Oct 8, 2021

• Fix weird commit

  

  mvargas33

  committed
  2f61e7b

  Copy full SHA for 2f61e7b

• Fix weird commit

  

  mvargas33

  committed
  9dd38aa

  Copy full SHA for 9dd38aa

• Update classifiers to use pair_similarity

  

  mvargas33

  committed
  5f68ed2

  Copy full SHA for 5f68ed2

• Updated rst docs

  

  mvargas33

  committed
  3d6450b

  Copy full SHA for 3d6450b

• Fix identation

  

  mvargas33

  committed
  7bce493

  Copy full SHA for 7bce493

Commits on Oct 11, 2021

• Update docs of score_pairs, get_metric

  

  mvargas33

  committed
  7e6584a

  Copy full SHA for 7e6584a

• Add deprecation Test. Fix identation

  

  mvargas33

  committed
  0b58f45

  Copy full SHA for 0b58f45

• Merge branch 'master' into score-deprecation

  

  mvargas33

  committed
  d4d3a9c

  Copy full SHA for d4d3a9c

• Merge branch 'score-deprecation' into feat-bilinear

  

  mvargas33

  committed
  d27bdf5

  Copy full SHA for d27bdf5

• Refactor to use pair_similarity instead of score_pairs

  

  mvargas33

  committed
  78a205c

  Copy full SHA for 78a205c

Commits on Oct 13, 2021

• Add more testing. Test refactor TBD

  

  mvargas33

  committed
  dde3576

  Copy full SHA for dde3576

• Tests are now parametrized

  

  mvargas33

  committed
  3020110

  Copy full SHA for 3020110

Commits on Oct 15, 2021

• Add bilinear in introduction

  

  mvargas33

  committed
  2746668

  Copy full SHA for 2746668

• Minor comment on use case

  

  mvargas33

  committed
  920e504

  Copy full SHA for 920e504

• More changes to sueprvised

  

  mvargas33

  committed
  7a24319

  Copy full SHA for 7a24319

• Changes in weakly Supervised

  

  mvargas33

  committed
  2f8ee76

  Copy full SHA for 2f8ee76

Commits on Oct 19, 2021

• Merge remote-tracking branch 'upstream/master' into score-deprecation

  

  mvargas33

  committed
  60c88a6

  Copy full SHA for 60c88a6

• Fixed changes requested 1

  

  mvargas33

  committed
  8c55970

  Copy full SHA for 8c55970

• Fixed changes requested 2

  

  mvargas33

  committed
  787a8d1

  Copy full SHA for 787a8d1

• Add equivalence test, p_dist == p_score

  

  mvargas33

  committed
  e14f956

  Copy full SHA for e14f956

• Fix tests and identation.

  

  mvargas33

  committed
  0941a32

  Copy full SHA for 0941a32

Commits on Oct 20, 2021

• Fixed changes requested 3

  

  mvargas33

  committed
  b019d85

  Copy full SHA for b019d85

• Fix identation

  

  mvargas33

  committed
  74df897

  Copy full SHA for 74df897

Commits on Oct 21, 2021

• Last requested changes

  

  mvargas33

  committed
  c62a4e7

  Copy full SHA for c62a4e7

• Merge branch 'score-deprecation' into feat-bilinear

  

  mvargas33

  committed
  526e4ba

  Copy full SHA for 526e4ba

• Replaced pair_similarity for paiir_score

  

  mvargas33

  committed
  2199724

  Copy full SHA for 2199724

• Last small detail

  

  mvargas33

  committed
  249e0fe

  Copy full SHA for 249e0fe

• Merge branch 'score-deprecation' into feat-bilinear

  

  mvargas33

  committed
  80f31ba

  Copy full SHA for 80f31ba

Commits on Oct 26, 2021

• Merge remote-tracking branch 'upstream/master' into feat-bilinear

  

  mvargas33

  committed
  8df44a4

  Copy full SHA for 8df44a4

• Classifiers only test classifiers methods now. + Standard doctrings now.

  

  mvargas33

  committed
  eef13bb

  Copy full SHA for eef13bb

• Work in tests. More comments. Some refactors

  

  mvargas33

  committed
  b952af0

  Copy full SHA for b952af0

Commits on Oct 27, 2021

• Learner lists for M and B learners. Separated test by kind. Mock class B weakly learners. Tests refactor.

  

  mvargas33

  committed
  7cc0d5e

  Copy full SHA for 7cc0d5e

• Moved mocks to test_utils.py, then refactor test_bilinear_mixin.py

  

  mvargas33

  committed
  5f6bdc2

  Copy full SHA for 5f6bdc2

Commits on Nov 3, 2021

• Merge branch 'master' into feat-bilinear

  

  mvargas33

  committed
  100a05d

  Copy full SHA for 100a05d

Commits on Nov 8, 2021

• Resolved observations in interoduction.rst

  

  mvargas33

  committed
  3bf5eae

  Copy full SHA for 3bf5eae

• Resolved all observations for supervised.rst and weakly_s.rst

  

  mvargas33

  committed
  acfd54b

  Copy full SHA for acfd54b

Commits on Nov 9, 2021

• Spellcheck

  

  mvargas33

  committed
  69bd9fe

  Copy full SHA for 69bd9fe

• Moved common test to test_base_metric.py . Refactor preprocessor test to avoid code duplication, trade-off with isinstance(). Added SCML basis that got lost in the list.

  

  mvargas33

  committed
  ade34cc

  Copy full SHA for ade34cc

Commits on Nov 18, 2021

• Fix docs annotations

  

  mvargas33

  committed
  7cfd432

  Copy full SHA for 7cfd432

• Second chunks of annotations.

  

  mvargas33

  committed
  0ac9e7a

  Copy full SHA for 0ac9e7a

Commits on Jun 21, 2022

• Merge branch 'master' into feat-bilinear

  perimosocordiae

  authored
  98340b0

  Copy full SHA for 98340b0