Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Add ChangedBehaviorWarning message for LMNN too #214

Merged
merged 2 commits into from
Jun 12, 2019
Merged

[MRG] Add ChangedBehaviorWarning message for LMNN too #214

merged 2 commits into from
Jun 12, 2019

Conversation

wdevazelhes
Copy link
Member

I forgot in #195 to add the changed behaviour warning for LMNN (which goes from init to auto),
This PR does it (and fixes also some typos for NCA)

@wdevazelhes wdevazelhes requested review from perimosocordiae and bellet and removed request for perimosocordiae June 12, 2019 08:39
@wdevazelhes
Copy link
Member Author

All tests pass so I guess we can merge if you all agree

@perimosocordiae perimosocordiae merged commit 999cb5b into scikit-learn-contrib:master Jun 12, 2019
@perimosocordiae
Copy link
Contributor

Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perimosocordiae perimosocordiae perimosocordiae approved these changes

@bellet bellet Awaiting requested review from bellet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wdevazelhes @perimosocordiae