[MRG] Uniformize initialization for all algorithms#195

Merged

perimosocordiae merged 56 commits intoscikit-learn-contrib:masterfrom wdevazelhes:feat/uniformized_initial_metric

Jun 7, 2019

+1,626-223

Commits on Apr 23, 2019

initiate PR
William de Vazelhes
committed

Commits on Apr 24, 2019

Revert "initiate PR"
William de Vazelhes
committed
FEAT: uniformize init for NCA and RCA
William de Vazelhes
committed
Let the check of num_dims be done in the other PR
William de Vazelhes
committed

Commits on May 2, 2019

Add metric initialization for algorithms that learn a mahalanobis matrix
William de Vazelhes
committed
Add initialization for MLKR
William de Vazelhes
committed
FIX: fix error message for dimension
William de Vazelhes
committed
FIX fix StringRepr for MLKR
William de Vazelhes
committed

Commits on May 3, 2019

FIX tests by reshaping to the right dataset size
William de Vazelhes
committed
Remove lda in docstring of MLKR
William de Vazelhes
committed

Commits on May 9, 2019

MAINT: Add deprecation for previous initializations
William de Vazelhes
committed
Update tests with new initialization
William de Vazelhes
committed
Make random init for mahalanobis metric generate an SPD matrix
William de Vazelhes
committed
Ensure the input mahalanobis metric initialization is symmetric, and say it should be SPD
William de Vazelhes
committed
various fixes
William de Vazelhes
committed
MAINT: various refactoring
William de Vazelhes
committed
FIX fix default covariance for SDML in tests
William de Vazelhes
committed

Commits on May 10, 2019

Enhance docstring
William de Vazelhes
committed
Set random state for SDML
William de Vazelhes
committed

Commits on May 13, 2019

Merge branch 'master' into feat/uniformized_initial_metric
William de Vazelhes
committed
Fix merge remove_spaces that was forgotten
William de Vazelhes
committed
Fix indent
William de Vazelhes
committed
XP: try to change the way we choose n_components to see if it fixes the test
William de Vazelhes
committed
Revert "XP: try to change the way we choose n_components to see if it fixes the test"
William de Vazelhes
committed
Be more tolerant in test
William de Vazelhes
committed
Add test for singular covariance matrix
William de Vazelhes
committed

Commits on May 14, 2019

Fix test_singular_covariance_init
William de Vazelhes
committed
DOC: update docstring saying pseudo-inverse
William de Vazelhes
committed
Revert "Fix test_singular_covariance_init"
William de Vazelhes
committed

Commits on May 15, 2019

Ensure definiteness before returning the inverse
William de Vazelhes
committed
wip deal with non definiteness
William de Vazelhes
committed

Commits on May 16, 2019

Rename init to prior for SDML and LSML
William de Vazelhes
committed

Commits on May 17, 2019

Update error messages with either prior or init
William de Vazelhes
committed
Remove message
William de Vazelhes
committed

Commits on May 18, 2019

A few nitpicks
William de Vazelhes
committed
PEP8 errors + change init in test
William de Vazelhes
committed
STY: PEP8 fixes
William de Vazelhes
committed

Commits on May 20, 2019

Address and remove TODOs
William de Vazelhes
committed

Commits on Jun 3, 2019

Replace init by prior for ITML
William de Vazelhes
committed
TST: fix ITML test with init changed into prior
William de Vazelhes
committed

Commits on Jun 4, 2019

Add precision for MMC
William de Vazelhes
committed

Commits on Jun 5, 2019

Add ChangedBehaviorWarning for the algorithms that changed
William de Vazelhes
committed
Merge branch 'master' into feat/uniformized_initial_metric
William de Vazelhes
committed
Address scikit-learn-contrib#195 (review)
William de Vazelhes
committed
Remove the warnings check since we now have a ChangedBehaviorWarning
William de Vazelhes
committed
Be more precise: it should not raise any ConvergenceWarningError
William de Vazelhes
committed
Merge branch 'master' into feat/uniformized_initial_metric
William de Vazelhes
committed

Commits on Jun 6, 2019

Address scikit-learn-contrib#195 (review)
William de Vazelhes
committed
FIX remaining comment
William de Vazelhes
committed
TST: update test error message
William de Vazelhes
committed
Improve readability
William de Vazelhes
committed

Commits on Jun 7, 2019

Address scikit-learn-contrib#195 (review)
William de Vazelhes
committed
Merge branch 'master' into feat/uniformized_initial_metric
William de Vazelhes
committed
TST: Fix docsting lmnn
William de Vazelhes
committed
Fix warning messages
William de Vazelhes
committed
Fix warnings messages changed
William de Vazelhes
committed