-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPD: Refactorization for MapieRegressor #308
Closed
thibaultcordier
wants to merge
23
commits into
master
from
300-refacto-adaptative-conformal-prediction
Closed
UPD: Refactorization for MapieRegressor #308
thibaultcordier
wants to merge
23
commits into
master
from
300-refacto-adaptative-conformal-prediction
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #308 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 32 +5
Lines 3475 3570 +95
Branches 360 371 +11
=========================================
+ Hits 3475 3570 +95
☔ View full report in Codecov by Sentry. |
This PR is obsolete, I close it to avoid any confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Propose a refactorization of some methods / classes / modules in order to prepare the PR of issue #300.
What we want is to lighten the
fit
andpredict
methods so that when we want to add new parameters to the conformity score function, we don't have to copy/paste the whole class and thus make the code easier to maintain.Type of change
Checklist
make lint
make type-check
make tests
make coverage
make doc