Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPD: Refactorization for MapieRegressor #308

Closed

Conversation

thibaultcordier
Copy link
Collaborator

@thibaultcordier thibaultcordier commented May 5, 2023

Description

Propose a refactorization of some methods / classes / modules in order to prepare the PR of issue #300.

What we want is to lighten the fit and predict methods so that when we want to add new parameters to the conformity score function, we don't have to copy/paste the whole class and thus make the code easier to maintain.

Type of change

  • Refactorization (non-breaking change which adds functionality)

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@thibaultcordier thibaultcordier self-assigned this May 5, 2023
@thibaultcordier thibaultcordier linked an issue May 5, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f1055e5) 100.00% compared to head (dd3c825) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #308   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        32    +5     
  Lines         3475      3570   +95     
  Branches       360       371   +11     
=========================================
+ Hits          3475      3570   +95     
Impacted Files Coverage Δ
mapie/__init__.py 100.00% <ø> (ø)
mapie/utils.py 100.00% <ø> (ø)
mapie/conformity_scores/__init__.py 100.00% <100.00%> (ø)
mapie/conformity_scores/conformity_scores.py 100.00% <100.00%> (ø)
...ie/conformity_scores/residual_conformity_scores.py 100.00% <100.00%> (ø)
mapie/quantile_regression.py 100.00% <100.00%> (ø)
mapie/regression/__init__.py 100.00% <100.00%> (ø)
mapie/regression/quantile_regression.py 100.00% <100.00%> (ø)
mapie/regression/regression.py 100.00% <100.00%> (ø)
mapie/regression/time_series_regression.py 100.00% <100.00%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thibaultcordier
Copy link
Collaborator Author

This PR is obsolete, I close it to avoid any confusion.

@thibaultcordier thibaultcordier deleted the 300-refacto-adaptative-conformal-prediction branch September 20, 2023 14:31
@thibaultcordier thibaultcordier restored the 300-refacto-adaptative-conformal-prediction branch September 20, 2023 14:31
@thibaultcordier thibaultcordier deleted the 300-refacto-adaptative-conformal-prediction branch October 17, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants