-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Implement covariance-based impact calculations #515
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #515 +/- ##
===========================================
- Coverage 100.00% 99.72% -0.28%
===========================================
Files 22 22
Lines 2096 2194 +98
Branches 347 378 +31
===========================================
+ Hits 2096 2188 +92
- Misses 0 2 +2
- Partials 0 4 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@alexander-held I am confused by the |
…ting statistical uncertainty in non-np-shift methods
In order to avoid inflating this PR, I will branch off this branch to continue the development of the GO-shifting method. I will also use a branch off this one to further utilise the impacts summary and expose them to user. Ideally would then prefer not to squash the history in this PR. This PR should also be updated with changes from #512 that use MINOS uncertainties for post-fit impact evaluations when available instead of the symmetric result from HESSIAN. |
This addresses #513.
To-do for this:
Expected missing coverage in this PR since they are implemented but not exposed in API:
These should be addressed in a follow-up PR where the API gets exposed and tests are added. This can probably be a PR on its own where we return a grouped impact table/plot.