Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow model_utils.prediction to skip uncertainty calculation #510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MoAly98
Copy link
Collaborator

@MoAly98 MoAly98 commented Feb 25, 2025

Addresses #417.

This solution returns zero uncertainty when calculation is skipped, avoiding change in ModelPrediction class.

* allow user to return yield predictions without computing uncertainties. A null uncertainty is returned instead. 

@MoAly98 MoAly98 self-assigned this Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ffa5ca2) to head (40fc316).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #510   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2094      2100    +6     
  Branches       347       348    +1     
=========================================
+ Hits          2094      2100    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoAly98 MoAly98 changed the title Allow model_utils.prediction to skip uncertainty calculation feat: Allow model_utils.prediction to skip uncertainty calculation Feb 28, 2025
@MoAly98 MoAly98 added the enhancement New feature or request label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant