Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow create_ntuples utility to accept an output directory from a CLI #508

Merged

Conversation

MoAly98
Copy link
Collaborator

@MoAly98 MoAly98 commented Feb 25, 2025

Adresses #507.

* Allow `create_ntuples` util script to accept output directory from CLI.

@MoAly98 MoAly98 self-assigned this Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0ede4d9) to head (bdeaa63).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #508   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2094      2094           
  Branches       347       347           
=========================================
  Hits          2094      2094           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoAly98 MoAly98 changed the title allow create_ntuples utility to accept an output directory from a CLI feat: allow create_ntuples utility to accept an output directory from a CLI Feb 28, 2025
@alexander-held alexander-held force-pushed the maly-create-ntuple-outdir-arg branch from 598965d to 9a08261 Compare February 28, 2025 15:48
Copy link
Member

@alexander-held alexander-held left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! I just fixed a typo and updated the docstring slightly to fit into the character limitation.

@alexander-held alexander-held merged commit 19ce6a1 into scikit-hep:master Feb 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants