-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect fixed parameters in n_dof calculation #479
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #479 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2094 2096 +2
Branches 347 347
=========================================
+ Hits 2094 2096 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks all good to me, I just want to give it a try with a few workspaces to sanity check this before merging. Thanks a lot for also having updated the tests too already!
Hi @alexander-held, I think this is ready and non-breaking change, unless you did tests which hint otherwise? |
986126d
to
fb93beb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this took so long to get merged and thanks again for fixing the behavior here!
* respect fixed parameters in degrees of freedom counting for goodness-of-fit
Solves #478 by passing fixed parameters to
model_utils.unconstrained_parameter_count
.