Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect fixed parameters in n_dof calculation #479

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

lorenzennio
Copy link
Contributor

Solves #478 by passing fixed parameters to model_utils.unconstrained_parameter_count.

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (19ce6a1) to head (0a379af).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #479   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2094      2096    +2     
  Branches       347       347           
=========================================
+ Hits          2094      2096    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@alexander-held alexander-held left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all good to me, I just want to give it a try with a few workspaces to sanity check this before merging. Thanks a lot for also having updated the tests too already!

@MoAly98
Copy link
Collaborator

MoAly98 commented Feb 28, 2025

Hi @alexander-held, I think this is ready and non-breaking change, unless you did tests which hint otherwise?

Copy link
Member

@alexander-held alexander-held left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long to get merged and thanks again for fixing the behavior here!

* respect fixed parameters in degrees of freedom counting for goodness-of-fit

@alexander-held alexander-held merged commit 22fc9b2 into scikit-hep:master Mar 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants