Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Poisson confidence intervals for data uncertainty in data/MC plots #466

Merged

Conversation

ekourlit
Copy link
Contributor

Adding frequentist confidence interval error bars on poisson distributed data. These changes only affect the way of plotting the data error bars on figures.

@alexander-held alexander-held changed the title poisson interval errors feat: Poisson confidence interval for data in data/MC plots Mar 17, 2024
@alexander-held alexander-held changed the title feat: Poisson confidence interval for data in data/MC plots feat: Poisson confidence intervals for data uncertainty in data/MC plots Mar 17, 2024
@alexander-held
Copy link
Member

alexander-held commented Mar 17, 2024

Thanks for adding this! As discussed offline, I'll fix the tests to get this merged.

For reference: these are "Garwood" intervals used through hist.intervals.poisson_interval.

* use Poisson confidence intervals to draw uncertainty for data points in data/MC plots
* implementation uses "Garwood" intervals via hist.intervals.poisson_interval

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (860a834) to head (a555e83).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #466   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2082      2083    +1     
  Branches       340       340           
=========================================
+ Hits          2082      2083    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-held alexander-held force-pushed the feat/poisson_interval_errors branch from 3b99623 to a555e83 Compare March 17, 2024 14:17
@alexander-held alexander-held merged commit 2baf8f5 into scikit-hep:master Mar 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants