Skip to content

chore(deps): update pre-commit hooks #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025
Merged

Conversation

pre-commit-ci bot and others added 3 commits April 7, 2025 21:36
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.11.0 → v0.11.4](astral-sh/ruff-pre-commit@v0.11.0...v0.11.4)
- [github.com/henryiii/validate-pyproject-schema-store: 2025.03.10 → 2025.04.07](henryiii/validate-pyproject-schema-store@2025.03.10...2025.04.07)
- [github.com/python-jsonschema/check-jsonschema: 0.31.3 → 0.32.1](python-jsonschema/check-jsonschema@0.31.3...0.32.1)
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii
Copy link
Collaborator

henryiii commented Apr 8, 2025

Fedora's failing due to:

>       out = build_wheel(str(dist))

/var/ARTIFACTS/work-pytestou3qcj9s/tests/plans/pytest/discover/default-0/tests/tests/test_setuptools_abi3.py:41: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/lib/python3.13/site-packages/setuptools/build_meta.py:421: in build_wheel
    return self._build_with_temp_dir(
/usr/lib/python3.13/site-packages/setuptools/build_meta.py:403: in _build_with_temp_dir
    self.run_setup()
/usr/lib/python3.13/site-packages/setuptools/build_meta.py:318: in run_setup
    exec(code, locals())
<string>:3: in <module>
    ???
/usr/lib/python3.13/site-packages/setuptools/__init__.py:117: in setup
    return distutils.core.setup(**attrs)
/usr/lib/python3.13/site-packages/setuptools/_distutils/core.py:171: in setup
    ok = dist.parse_command_line()
/usr/lib/python3.13/site-packages/setuptools/_distutils/dist.py:472: in parse_command_line
    args = self._parse_command_opts(parser, args)
/usr/lib/python3.13/site-packages/setuptools/dist.py:852: in _parse_command_opts
    nargs = _Distribution._parse_command_opts(self, parser, args)
/usr/lib/python3.13/site-packages/setuptools/_distutils/dist.py:531: in _parse_command_opts
    cmd_class = self.get_command_class(command)
/usr/lib/python3.13/site-packages/setuptools/dist.py:691: in get_command_class
    from .command.bdist_wheel import bdist_wheel
/usr/lib/python3.13/site-packages/setuptools/command/bdist_wheel.py:25: in <module>
    from wheel.metadata import pkginfo_to_metadata

I think this means there's a mismatch in versions for wheel and setuptools.

@LecrisUT
Copy link
Collaborator

LecrisUT commented Apr 8, 2025

Oh, but those tests are running with PyPI dependencies. I will move the installation part to a more visible location.

22:11:18             out:   Created wheel for scikit_build_core: filename=scikit_build_core-0.11.0-py3-none-any.whl size=179861 sha256=7d0d1a21ad0c44295c7dadc5d4fa4da85fa4d5314296e91e4cff057c86895f71
22:11:18             out:   Stored in directory: /tmp/pip-ephem-wheel-cache-ewz2_5x5/wheels/e3/6f/de/fc349bec4d27addee8711dbbc1b7adbea36d657c91a4c6f9a9
22:11:18             out: Successfully built scikit_build_core
22:11:18             out: Installing collected packages: distlib, pyproject_hooks, pybind11, pluggy, platformdirs, pathspec, packaging, iniconfig, filelock, execnet, cattrs, wheel, virtualenv, scikit_build_core, pytest, build, pytest-xdist, pytest-subprocess
22:11:19             out: Successfully installed build-1.2.2.post1 cattrs-24.1.3 distlib-0.3.9 execnet-2.1.1 filelock-3.18.0 iniconfig-2.1.0 packaging-24.2 pathspec-0.12.1 platformdirs-4.3.7 pluggy-1.5.0 pybind11-2.13.6 pyproject_hooks-1.2.0 pytest-8.3.5 pytest-subprocess-1.5.3 pytest-xdist-3.6.1 scikit_build_core-0.11.0 virtualenv-20.30.0 wheel-0.46.1
22:11:19             err: WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager, possibly rendering your system unusable.It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv. Use the --root-user-action option if you know what you are doing and want to suppress this warning.

Seems like I've added a similar workaround in #800. Maybe I missed something in the dependencies since I am only installing [test] there so far.

@henryiii henryiii merged commit 57d231e into main Apr 9, 2025
64 checks passed
@henryiii henryiii deleted the pre-commit-ci-update-config branch April 9, 2025 03:23
@henryiii
Copy link
Collaborator

henryiii commented Apr 9, 2025

I'm hiding the warning for now but setuptools/wheel might need to work this out. Might be a 0.46.1 issue if it's wheel, that just came out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants