-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support having multiple crr locations configured in the queueProcessor #2632
base: development/9.1
Are you sure you want to change the base?
Conversation
Hello kerkesni,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 2 files with indirect coverage changes
@@ Coverage Diff @@
## improvement/BB-647 #2632 +/- ##
======================================================
+ Coverage 73.09% 73.18% +0.09%
======================================================
Files 201 201
Lines 13413 13415 +2
======================================================
+ Hits 9804 9818 +14
+ Misses 3599 3587 -12
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
a648dcc
to
53c9fcd
Compare
QueueProcessor currently sets the destination host to the host of the last crr site in the bootstrap list. This works in the 7.x branch as we filter the bootstrap list to only contain the relevant site. This filtering was done in the entrypoint of the QueueProcessor (i.e task.js) which changed in 8.x and 9.x. Issue: BB-662
53c9fcd
to
09fd95f
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM (codecov still reports that all lines were not covered, yet the comment says the opposite...)
The comments point to a previous run of codecov which is weird, but i added tests explicitly for those cases so they should be covered. |
if (dest.echo) { | ||
this._setupEcho(); | ||
} | ||
const dest = destConfig.bootstrapList.find(d => d.site === this.site); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this I gather that the QueueProcessor only uses a single site from dest.bootstrapList
: so should we not instead "select" the appropriate site's bootstrap list/endpoint(s) when building destConfig
?
(since building every destConfig is done once, when loading the config, this would also allow to do it efficiently, without going searching linearly for every site)
QueueProcessor currently sets the destination host to the host of the last crr site in the bootstrap list, so when having multiple crr locations configured this will not work.
Issue: BB-662