Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Navigation): allow better links on navigation items #4768

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

Improve <Navigation.Item /> component by adding props rel and target. Previously a href item meant external link, it has now changed. Take this in consideration as your links might not open in a new browser and not have the external icon anymore.

New props rel and target on <MenuV2.Item />

@matthprost matthprost added the enhancement New feature or request label Feb 14, 2025
@matthprost matthprost requested review from atissedrescaleway and a team February 14, 2025 16:32
@matthprost matthprost self-assigned this Feb 14, 2025
@matthprost matthprost requested a review from lisalupi as a code owner February 14, 2025 16:32
@matthprost matthprost requested review from BABAK0T0 and lisalupi and removed request for a team February 14, 2025 16:32
Copy link

changeset-bot bot commented Feb 14, 2025

🦋 Changeset detected

Latest commit: fcae251

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/plus Minor
@ultraviolet/ui Minor
@ultraviolet/form Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.04%. Comparing base (aec2154) to head (fcae251).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4768   +/-   ##
=======================================
  Coverage   89.04%   89.04%           
=======================================
  Files         229      229           
  Lines        8013     8013           
  Branches     3640     3688   +48     
=======================================
  Hits         7135     7135           
  Misses        878      878           
Files with missing lines Coverage Δ
...kages/ui/src/components/MenuV2/components/Item.tsx 86.66% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aec2154...fcae251. Read the comment docs.

@matthprost matthprost merged commit 3b8a89a into main Feb 17, 2025
16 checks passed
@matthprost matthprost deleted the fix/navigation-as-link branch February 17, 2025 10:32
@scaleway-bot scaleway-bot mentioned this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants