Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dialog): to have correct icon with sentiment danger and warning #4729

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Fix <Dialog /> component to have correct icon when sentiment is warning or danger

@matthprost matthprost added the bug Something isn't working label Feb 3, 2025
@matthprost matthprost requested a review from a team February 3, 2025 10:26
@matthprost matthprost self-assigned this Feb 3, 2025
@matthprost matthprost requested review from BABAK0T0 and removed request for a team February 3, 2025 10:27
@matthprost matthprost requested a review from lisalupi as a code owner February 3, 2025 10:27
@matthprost matthprost requested a review from Lawndlwd February 3, 2025 10:27
Copy link

changeset-bot bot commented Feb 3, 2025

🦋 Changeset detected

Latest commit: eaf940f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.99%. Comparing base (228735e) to head (eaf940f).
Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4729   +/-   ##
=======================================
  Coverage   88.98%   88.99%           
=======================================
  Files         227      227           
  Lines        7972     7970    -2     
  Branches     3619     3618    -1     
=======================================
- Hits         7094     7093    -1     
+ Misses        878      877    -1     
Files with missing lines Coverage Δ
packages/ui/src/components/Dialog/index.tsx 100.00% <100.00%> (+5.00%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2585985...eaf940f. Read the comment docs.

@matthprost matthprost merged commit fc68c84 into main Feb 5, 2025
15 checks passed
@matthprost matthprost deleted the fix/dialog-icon branch February 5, 2025 09:53
@scaleway-bot scaleway-bot mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants