New Syntax for Capture Variables and Explicit Capture Polymorphism v2 #22902
+628
−263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cap` is now a soft modifier and we abolish separate cap lists.
13 tasks
Neg test use-capset revealed that type param clauses are incorrectly parsed when a capset parameter has an annotation.
|
I think it would be good to open a thread on contributors to discuss the new syntax. That way, p[eople can weigh in with opinions and proposals. |
noti0na1
requested changes
Apr 3, 2025
| @@ -1917,6 +1917,23 @@ class ExpectedTypeBoundOrEquals(found: Token)(using Context) | |||
| |""" | |||
| } | |||
|
|
|||
| class ExpectedCaptureBoundOrEquals(found: Token)(using Context) | |||
There was a problem hiding this comment.
We need some check tests for the error message.
| @@ -8,37 +8,37 @@ trait BoundsTest: | |||
|
|
|||
| val b: Bar^ = ??? | |||
|
|
|||
| def testTransMixed[A^, | |||
There was a problem hiding this comment.
We can add a test where the bound of a type parameter depends on the capture parameters in the same list.
| @@ -2283,6 +2325,15 @@ object Parsers { | |||
| else atSpan((t.span union cbs.head.span).start) { ContextBounds(t, cbs) } | |||
| } | |||
|
|
|||
| /** CaptureSetAndCtxBounds ::= CaptureSetBounds [`:` ContextBounds] -- under captureChecking | |||
| */ | |||
| def captureSetAndCtxBounds(pname: TypeName): Tree = { | |||
There was a problem hiding this comment.
Let's add a test for capture param with ctx bound.
There was a problem hiding this comment.
It's already in pos test cap-paramlists7.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22490
Builds on #22725
Supersedes #22758
This aim of this PR is reducing the clunkyness of the explicit capture polymorphism syntax following internal discussions.
syntax.md.Add specialized syntax error messages for cap lists & co.(make separate issue)[C^]syntax for good.Make cap members and lists pretty-printed (with option to turn off).(separate issue, let's wait for under-the-hood changes to the capset representation)