Completions for requests just before string #22894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Apr 1, 2025
presentation-compiler/test/dotty/tools/pc/tests/completion/BlaSuite.scala
Outdated
Show resolved
Hide resolved
- extractor for StringContext apply - cleanup
|
advices on names are most welcome! |
tgodzik
reviewed
Apr 2, 2025
| | val VersionRegex = "".r | ||
| | VersionRe@@"1234" | ||
| """.stripMargin, | ||
| "|VersionRegex: Regex".stripMargin |
There was a problem hiding this comment.
Should we show VersionRegex if it doesn't have anything to do with StringContext? Could we have a check that only shows things like raw ?
There was a problem hiding this comment.
We want to show all completions. This is unintended behavior that there were no completions just before string due to String context desugaring. All other completions work like that
There was a problem hiding this comment.
for example you have a string which you want to wrap in Some, and you had no completions at all
rochala
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22514