Revert unconditional lint of Inlined expansion #22815
Merged
+284
−363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
cleanup/untried
branch
from
7ca6c46 to
0b3e859
Compare
jchyb
approved these changes
Mar 23, 2025
There was a problem hiding this comment.
Can also confirm this partial revert fixes the issue in the linked project. Minimisation might be hard (or even impossible, if this is not an infinite loop, but "just" a compilation speed regression), so I am fine with not having the dedicated test for that here.
Thank you @som-snytt!
jchyb
added
the
backport:nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tweak to lint Inlined is reverted, on suspicion that it is the root cause of #22812 . (Investigation ongoing.) (If it reverts without a test change, then it doesn't have test coverage.)
Gather legacy tests about type parameters and delete the
untriedtest files. Same forunusedtest files; removing check and flags files forwarn-unused-privatesis a follow-up chore for a previous PR.Fixes #22812 (provisionally)