Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The layout wasn't working as expected due to incorrect flex-col/flex-row setup, especially on different screen sizes. The proposed changes provide a clean layout for all screen sizes.
Additional Information
Tailwind follows a mobile-first approach, meanwhile the SE-2 homepage seemed to have been following a desktop-first approach: https://tailwindcss.com/docs/responsive-design#working-mobile-first which led to unexpected behaviour.
Because of this, the example:
flex-col sm:flex-row
does not work as expected. On small screens, it actually defaults toflex-col
. Since when tailwind seesflex-col
, it actually interprets it assm:flex-col
.Proposed Changes
The
Connected Addresses
section now simply is aflex-col
, since with the (now removed)sm:flex-row
, mobile screens would have content displaying horizontally off-screen.The
Call To Action
section inhibits the mobile first approach by defaulting to aflex-col
and on screens medium or larger it turns into aflex-row
.Your ENS/address: jacobhomanics.eth