Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to homepage layout #1064

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

JacobHomanics
Copy link
Contributor

@JacobHomanics JacobHomanics commented Mar 10, 2025

Description

The layout wasn't working as expected due to incorrect flex-col/flex-row setup, especially on different screen sizes. The proposed changes provide a clean layout for all screen sizes.

Additional Information

Tailwind follows a mobile-first approach, meanwhile the SE-2 homepage seemed to have been following a desktop-first approach: https://tailwindcss.com/docs/responsive-design#working-mobile-first which led to unexpected behaviour.

Because of this, the example: flex-col sm:flex-row does not work as expected. On small screens, it actually defaults to flex-col. Since when tailwind sees flex-col, it actually interprets it as sm:flex-col.

Proposed Changes

The Connected Addresses section now simply is a flex-col, since with the (now removed) sm:flex-row, mobile screens would have content displaying horizontally off-screen.

The Call To Action section inhibits the mobile first approach by defaulting to a flex-col and on screens medium or larger it turns into a flex-row.

Your ENS/address: jacobhomanics.eth

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JacobHomanics! yes we had small horizontal scroll on main branch in mobile screens... this fixes it too 🙌

@technophile-04 technophile-04 merged commit df20b81 into scaffold-eth:main Mar 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants