Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import on wagmi package #1061

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

maykelxyz
Copy link
Contributor

Description

Creating production build using npm run build causes build errors:
image

  • Reference of getPublicClient should be changed from import @wagmi/core to wagmi/actions
  • Also fixes the issue publicClient is possibly undefined in:
      //useTransactor.tsx
     //`publicClient` is possibly undefined
      transactionReceipt = await publicClient.waitForTransactionReceipt({
        hash: transactionHash,
        confirmations: options?.blockConfirmations,
      });
      notification.remove(notificationId);

Additional Information

Your ENS/address:
0xBa9Da840bA7B5d0F227716f2e7266675cE697e9D

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating production build using npm run build causes build errors:

Ideally you should have run yarn run build since we use yarn to manage the dependencies

But yeah importing it from wagmi/actions makes more sense!

Thanks @maykelxyz 🙌

@technophile-04 technophile-04 merged commit c5c8139 into scaffold-eth:main Mar 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants