Update tests for fixing unifyCompound() and unifyComplex() ordering of pseudo class/element selectors #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goodwine
force-pushed
the
fix-unify-compound-changing-order
branch
from
26221fd
to
432e848
Compare
nex3
approved these changes
Sep 18, 2024
|
I added some changes to the tests to catch more potentially erroneous behaviors (or maybe those behaviors are intended haha), PTAL |
…f pseudo class/element selectors
Goodwine
force-pushed
the
fix-unify-compound-changing-order
branch
from
0053ae9
to
92da5eb
Compare
nex3
reviewed
Sep 19, 2024
| ================================================================================ | ||
| <===> order/cross_pseudo_element/input.scss | ||
| @use "sass:selector"; | ||
| a {b: selector.unify(".x", "::y.z")} |
There was a problem hiding this comment.
I think we shouldn't test this case, because it's functionally meaningless to begin with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/dart-sass#2335
See sass/dart-sass#2350
[skip dart-sass]