Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sanity): translation cleanup #7788

Closed
wants to merge 5 commits into from
Closed

Conversation

RitaDias
Copy link
Contributor

@RitaDias RitaDias commented Nov 11, 2024

Description

closing for now since this impacts the tests quite a lot - more than anticipated - returning to this later

What to review

Testing

Notes for release

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 9:38am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 9:38am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 9:38am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 9:38am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 9:38am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 9:38am

@RitaDias RitaDias changed the title Translation clean up refactor(sanity): translation cleanup Nov 12, 2024
Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Component Testing Report Updated Nov 12, 2024 9:36 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 9s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 52s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 42s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 49s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 43s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 58s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Nov 12, 2024

⚡️ Editor Performance Report

Updated Tue, 12 Nov 2024 09:38:10 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 18.5 efps (54ms) 12.8 efps (78ms) +24ms (+44.4%) 🔴
article (body) 60.1 efps (17ms) 54.8 efps (18ms) +2ms (+9.6%)
article (string inside object) 19.2 efps (52ms) 13.5 efps (74ms) +22ms (+42.3%) 🔴
article (string inside array) 16.4 efps (61ms) 11.4 efps (88ms) +27ms (+44.3%) 🔴
recipe (name) 30.3 efps (33ms) 20.0 efps (50ms) +17ms (+51.5%) 🔴
recipe (description) 33.9 efps (30ms) 21.3 efps (47ms) +18ms (+59.3%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.7 efps (68ms) 5.8 efps (174ms) +106ms (+155.1%) 🔴
synthetic (string inside object) 15.2 efps (66ms) 6.1 efps (164ms) +98ms (+147.7%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 54ms 58ms 67ms 246ms 361ms 13.7s
article (body) 17ms 20ms 29ms 154ms 328ms 5.9s
article (string inside object) 52ms 57ms 64ms 190ms 275ms 8.5s
article (string inside array) 61ms 66ms 79ms 221ms 567ms 9.2s
recipe (name) 33ms 36ms 50ms 91ms 24ms 10.4s
recipe (description) 30ms 31ms 40ms 66ms 7ms 6.2s
recipe (instructions) 6ms 8ms 9ms 26ms 0ms 3.3s
synthetic (title) 68ms 71ms 78ms 130ms 1023ms 15.9s
synthetic (string inside object) 66ms 71ms 81ms 486ms 1850ms 10.7s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 78ms 85ms 159ms 308ms 2997ms 17.0s
article (body) 18ms 24ms 42ms 281ms 616ms 6.9s
article (string inside object) 74ms 79ms 84ms 370ms 2478ms 11.2s
article (string inside array) 88ms 93ms 100ms 324ms 3303ms 12.2s
recipe (name) 50ms 52ms 57ms 95ms 886ms 11.6s
recipe (description) 47ms 49ms 50ms 106ms 781ms 7.8s
recipe (instructions) 6ms 8ms 9ms 21ms 0ms 3.3s
synthetic (title) 174ms 183ms 266ms 510ms 10162ms 28.5s
synthetic (string inside object) 164ms 170ms 187ms 428ms 8031ms 19.3s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant