条件判定(KEYCODE)が常にfalseになる警告修正 #2023
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Build sakura 1.0.4462 completed (commit e341d38dd2 by @gorogoro123) |
berryzplus
approved these changes
Mar 16, 2025
| str = profile_data::ToString(code); | ||
| ASSERT_STREQ(L"\x01", str.c_str()); | ||
|
|
||
| code = 0x61; |
There was a problem hiding this comment.
Suggested change
| code = 0x61; | |
| code = 'a'; |
| /*! | ||
| * @brief ToString(KEYCODE)のテスト | ||
| */ | ||
| TEST(profile_data, ToString_KEYCODE) |
There was a problem hiding this comment.
219行目の TryParse_WCHAR と構成を合わせるとよりよいかもです。
やってることは
- 妥当な値を渡して parse できることの確認。
- 不正な値を渡して parse できないことの確認。（値が変わらない）
- 妥当な値を渡して parse できることの確認。
です。
書いてくれたものほうがより細かい確認をできていますが、上記2の確認ができてないです。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR対象
カテゴリ
PR の背景
Clang/LLVM でbuild時に "-Wtautological-constant-out-of-range-compare" のwarningが出力される。
CDataProfile.h(229,39): warning : result of comparison of constant 128 with expression of type 'KEYCODE' (aka 'char') is always false [-Wtautological-constant-out-of-range-compare]
KEYCODE型(char) の変数の範囲は -128~127、128は範囲外。
仕様・動作説明
PR の影響範囲
影響なし。
テスト内容
変更前後で unit test が PASS することを確認します。
関連 issue, PR
#1548
参考資料
https://cpprefjp.github.io/reference/limits/numeric_limits.html