format関数を使えるようにC++20に移行する #2014
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++20では u8リテラル文字列 と MBCSリテラル文字列 が別型となり、ビルドが通らなくなるため。
C++20では u8リテラル文字列 と MBCSリテラル文字列 が別型となり、ビルドが通らなくなるため。
C++コンパイラーのC++準拠レベルをC++20にして std::format を使えるようにする C++20対応は vs2019 からなので Appveyor のビルドイメージを変更する
|
❌ Build sakura 1.0.4451 failed (commit aa72867765 by @berryzplus) |
This reverts commit 8b29033.
C++コンパイラーのC++準拠レベルをC++20にして std::format を使えるようにする
|
❌ Build sakura 1.0.4452 failed (commit 867dc47e77 by @berryzplus) |
|
状況初回ビルドは 今後の対応
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR対象
カテゴリ
PR の背景
現状のコードベースは
C++17準拠で、C++のフォーマット関数を利用できずに不便です。仕様・動作説明
コードベースの準拠レベルを
C++20に変更し、C++のフォーマット関数を利用できるようにします。PR の影響範囲
機能的な影響はありません。
vs2017ではビルドできなくなります。テスト内容
関連 issue, PR
参考資料