Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Image Generator #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

susheel009
Copy link

Catboys API image generator is not working so I replaced it with a similar image generator

Catboys API image generator is not working so I replaced it with a similar image generator
Copy link

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes you've made represent a successful update! Here's a review:

Functionality:

The core functionality remains the same: displaying a loading message and spinner while fetching an image, then updating the button and image once the data is received.
Change:

The key change is the API endpoint used. You've switched from https://api.catboys.com/img to https://nekos.life/api/v2/img/neko. This means you're now fetching images of cats (nekomimi) instead of catboys.
Overall:

This update effectively modifies the image source to display a different type of image (neko) while preserving the core logic of the code.

Additional Considerations:

API Differences: It's important to check if the new API (https://nekos.life/api/v2/img/neko) has any structural differences in the returned data compared to the previous one. If so, you might need to adjust how you access the image URL within the data object.
Clarity: Depending on the purpose of your code, you might consider renaming the button text or providing a visual cue (like an icon change) to indicate the switch from catboys to nekos. This improves user clarity.
Nice Work!

This update demonstrates a well-executed change while maintaining the overall functionality of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants