Skip to content

Fix gap spkg-configure.m4 #39926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix gap spkg-configure.m4 #39926

wants to merge 1 commit into from

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Apr 11, 2025

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

cc @dimpase

Copy link

Documentation preview for this PR (built with commit e47a243; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @roed314 - please turn this to positive review

@dimpase
Copy link
Member

dimpase commented Apr 11, 2025

@isuruf - are you still at Illinois? We're neighbours then, more or less.

@isuruf
Copy link
Member Author

isuruf commented Apr 11, 2025

Yes, still in Urbana, IL

@dimpase
Copy link
Member

dimpase commented Apr 11, 2025

Evanston, IL here. Are you guys by any chance interested in any kind of collaboration with Northwestern ?

@isuruf
Copy link
Member Author

isuruf commented Apr 11, 2025

I graduated and work at Quansight now

@dimpase
Copy link
Member

dimpase commented Apr 11, 2025

I graduated and work at Quansight now

yes, I know. I meant things like internships, possible other kinds of handouts to students...

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 13, 2025
sagemathgh-39926: Fix gap spkg-configure.m4
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

cc @dimpase
    
URL: sagemath#39926
Reported by: Isuru Fernando
Reviewer(s): Dima Pasechnik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants