-
-
Notifications
You must be signed in to change notification settings - Fork 597
Fix gap spkg-configure.m4 #39926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Fix gap spkg-configure.m4 #39926
Conversation
Documentation preview for this PR (built with commit e47a243; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @roed314 - please turn this to positive review
@isuruf - are you still at Illinois? We're neighbours then, more or less. |
Yes, still in Urbana, IL |
Evanston, IL here. Are you guys by any chance interested in any kind of collaboration with Northwestern ? |
I graduated and work at Quansight now |
yes, I know. I meant things like internships, possible other kinds of handouts to students... |
sagemathgh-39926: Fix gap spkg-configure.m4 <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> cc @dimpase URL: sagemath#39926 Reported by: Isuru Fernando Reviewer(s): Dima Pasechnik
📝 Checklist
⌛ Dependencies
cc @dimpase