update lcalc to version 2.1.0

[dimpase]

a long-awaited update to 2.1.0, crucial to supporting Apple's clang 17.
Will fix #39897

📝 Checklist

• The title is concise and informative.
• The description explains in detail what this PR is about.
• I have linked a relevant issue or discussion.
• I have created tests covering the changes.
• I have updated the documentation and checked the documentation preview.

⌛ Dependencies

[dimpase]

@behackl - does this work for you?

@orlitzky - is there any reason for Gentoo to use an uploaded .xz tarball, rather than one provided by GitLab?
(Edit - now I know - one needs ./configure present)

[behackl]

I perhaps did something wrong, I thought running make lcalc-clean && make lcalc after applying the changes here would clean and rebuild the package properly, but it appears there is a problem with configure then?

[lcalc-2.1.0] Using cached file /Users/behackl/code/sage-devel/upstream/lcalc-2.1.0.tar.bz2
[lcalc-2.1.0] Setting up build directory /Users/behackl/code/sage-devel/local/var/tmp/sage/build/lcalc-2.1.0
[lcalc-2.1.0] No patch files found in ../patches
[lcalc-2.1.0] Host system: Darwin geonor.local 24.4.0 Darwin Kernel Version 24.4.0: Wed Mar 19 21:11:02 PDT 2025; root:xnu-11417.101.15~1/RELEASE_ARM64_T8132 arm64
[lcalc-2.1.0] C compiler: gcc, Apple clang version 17.0.0 (clang-1700.0.13.3), Target: arm64-apple-darwin24.4.0, Thread model: posix, InstalledDir: /Library/Developer/CommandLineTools/usr/bin
[lcalc-2.1.0] No stamp file for package 'lcalc' in /Users/behackl/code/sage-devel/local/var/lib/sage/installed
[lcalc-2.1.0] No spkg-legacy-uninstall script; nothing to do
[lcalc-2.1.0] [spkg-build] Configuring lcalc-2.1.0
[lcalc-2.1.0] [spkg-build] /Users/behackl/code/sage-devel/build/bin/sage-dist-helpers: line 167: ./configure: No such file or directory
[lcalc-2.1.0] [spkg-build] /Users/behackl/code/sage-devel/build/bin/sage-dist-helpers: line 169: ./configure: No such file or directory
[lcalc-2.1.0] [spkg-build] ********************************************************************************
[lcalc-2.1.0] [spkg-build] Error configuring lcalc-2.1.0
[lcalc-2.1.0] [spkg-build] ********************************************************************************
[lcalc-2.1.0] ************************************************************************
[lcalc-2.1.0] Error building package lcalc-2.1.0
[lcalc-2.1.0] ************************************************************************

I can try a fresh build after running make distclean if that is the proper course of action to test this?

[dimpase]

oh, sorry. must be wrong tarball, without configure etc. I'll fix it.

[behackl]

I don't know whether it is a good idea given that pretty much none of our other packages appear to do it, but this change also fixes it:

--- a/build/pkgs/lcalc/spkg-build.in
+++ b/build/pkgs/lcalc/spkg-build.in
@@ -1,3 +1,4 @@
 cd src
+autoreconf -ivf
 sdh_configure --with-pari
 sdh_make

(I did have to separately brew install automake though.)

[dimpase]

no, we don't assume that autotools are available, we really need another tarball (available on gitlab too). I'll post an update shortly.

[github-actions]

Documentation preview for this PR (built with commit e586ab1; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

[behackl]

With the change from the last commit, lcalc builds successfully on my machine. (With the other local patches mentioned in my report included on top, Sage builds successfully overall.)

Is there anything in particular I can or should test before approving this PR?

[dimpase]

I think lcalc 2.1.0 is tested enough, it's already in Conda and in a few Linux distros.

[dimpase]

(With the other local patches mentioned in my report included on top, Sage builds successfully overall.)

of these patches, only the boost-related one is needed on another platform. Apple Clang 17 appears to be an outlier, only available on newer arm64 Macs, and stricter than mainline Clangs 18 and 20.

[behackl]

This looks good as far as I can tell. Thanks!