Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in exception handling code of gap interface #39906

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Apr 8, 2025

Previously the (newly-added) test would raise

    TypeError: argument of type 'RuntimeError' is not iterable

instead, because RuntimeError(exc) will create an object that is RuntimeError(RuntimeError('Gap produced error output...')) instead, and later there is a check that is if "Input/output error" in msg.args[0]: which would fail if msg.args[0] is not a string.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Apr 8, 2025

Documentation preview for this PR (built with commit 01782d6; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 13, 2025
sagemathgh-39906: Fix error in exception handling code of gap interface
    
Previously the (newly-added) test would raise

```
    TypeError: argument of type 'RuntimeError' is not iterable
```

instead, because `RuntimeError(exc)` will create an object that is
`RuntimeError(RuntimeError('Gap produced error output...'))` instead,
and later there is a check that is `if "Input/output error" in
msg.args[0]:` which would fail if `msg.args[0]` is not a string.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39906
Reported by: user202729
Reviewer(s): Travis Scrimshaw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants