Skip to content

Fix conversion from symbolic series to lazy Laurent series #39899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

yashashwi-s
Copy link

@yashashwi-s yashashwi-s commented Apr 7, 2025

Fix conversion from symbolic series to lazy Laurent series

This PR partially fixes issue #39840, addressing only the first error when converting symbolic series to lazy Laurent series.


Original Issue

When attempting to convert a symbolic series:

var("x")
f = (1/x + sqrt(x + 1)).series(x)

The following error occurred with LazyLaurentSeriesRing:

ValueError: the valuation must be specified

The second error with LazyPowerSeriesRing remains unresolved:

TypeError: Substitution using function-call syntax and unnamed arguments has been removed...

🔧 Fix Implementation

Explicit handling for SymbolicSeries objects was added to the _element_constructor_ method to properly determine the valuation and extract coefficients.


✅ Testing

Manual testing confirms that the LazyLaurentSeriesRing conversion now works correctly:

var("x")
f = (1/x + sqrt(x + 1)).series(x)
LazyLaurentSeriesRing(QQ, "x")(f)  # Works now

⚠️ The LazyPowerSeriesRing conversion issue will be addressed in a separate PR.


📋 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@user202729
Copy link
Contributor

Do add some doctest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants