Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump tj-actions/changed-files from 45 to 46 #39722

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 17, 2025

Bumps tj-actions/changed-files from 45 to 46.

Release notes

Sourced from tj-actions/changed-files's releases.

v46

[!WARNING]
Security Alert: A critical security issue was identified in this action due to a compromised commit: 0e58ed8671d6b60d0890c21b07f8835ace038e67.

This commit has been removed from all tags and branches, and necessary measures have been implemented to prevent similar issues in the future.

Action Required:

  • Review your workflows executed between March 14 and March 15. If you notice unexpected output under the changed-files section, decode it using the following command: echo 'xxx' | base64 -d | base64 -d
    If the output contains sensitive information (e.g., tokens or secrets), revoke and rotate those secrets immediately.
  • If your workflows reference this commit directly by its SHA, you must update them immediately to avoid using the compromised version.
  • If you are using tagged versions (e.g., v35, v44.5.1), no action is required as these tags have been updated and are now safe to use.

Additionally, as a precaution, we recommend rotating any secrets that may have been exposed during this timeframe to ensure the continued security of your workflows.

Changes in v46.0.1

What's Changed

Full Changelog: tj-actions/changed-files@v46...v46.0.1


Changes in v46.0.0

What's Changed

New Contributors

Full Changelog: tj-actions/changed-files@v45.0.5...v46.0.0

What's Changed

Full Changelog: tj-actions/changed-files@v45.0.5...v46.0.0

... (truncated)

Changelog

Sourced from tj-actions/changed-files's changelog.

Changelog

46.0.1 - (2025-03-16)

🔄 Update

  • Updated README.md (#2473)

Co-authored-by: github-actions[bot] (2f7c5bf) - (github-actions[bot])

  • Sync-release-version.yml to use signed commits (#2472) (4189ec6) - (Tonye Jack)

46.0.0 - (2025-03-16)

🐛 Bug Fixes

  • Update update-readme.yml to sign-commits (#2468) (0f1ffe6) - (Tonye Jack)
  • Update permission in update-readme.yml workflow (#2467) (ddef03e) - (Tonye Jack)
  • Update github workflow update-readme.yml (#2466) (9c2df0d) - (Tonye Jack)

➖ Remove

  • Deleted renovate.json (e37e952) - (Tonye Jack)

🔄 Update

  • Sync-release-version.yml (#2471) (4cd184a) - (Tonye Jack)
  • Updated README.md (#2469)

Co-authored-by: github-actions[bot] (5cbf220) - (github-actions[bot])

📚 Documentation

  • Update docs to highlight security issues (#2465) (6525332) - (Tonye Jack)

45.0.9 - (2025-03-15)

🐛 Bug Fixes

  • deps: Update dependency @​octokit/rest to v21.1.1 (#2435) (fb8dcda) - (renovate[bot])
  • deps: Update dependency @​octokit/rest to v21.1.0 (#2394) (7b72c97) - (renovate[bot])
  • deps: Update dependency yaml to v2.7.0 (#2383) (5f974c2) - (renovate[bot])

⚙️ Miscellaneous Tasks

  • deps: Lock file maintenance (#2460) (9200e69) - (renovate[bot])
  • deps: Update dependency @​types/node to v22.13.10 (#2459) (e650cfd) - (renovate[bot])
  • deps: Update dependency eslint-config-prettier to v10.1.1 (#2458) (82af21f) - (renovate[bot])
  • deps: Update dependency eslint-config-prettier to v10.1.0 (#2457) (82fa4a6) - (renovate[bot])
  • deps: Update peter-evans/create-pull-request action to v7.0.8 (#2455) (315505a) - (renovate[bot])
  • deps: Update dependency @​types/node to v22.13.9 (#2454) (c8e1cdb) - (renovate[bot])

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 45 to 46.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v45...v46)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Mar 17, 2025
Copy link

Documentation preview for this PR (built with commit 73abffd; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tobiasdiez
Copy link
Contributor

@sagemath/core IMPORTANT: we have been affected by the compromised action, see https://github.com/sagemath/sage/actions/runs/13866682283/job/38807100680#step:5:74
If you decode it, you see "system.github.token":{"value":"<value>","isSecret":true}

According to https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#considering-cross-repository-access, the GITHUB_TOKEN that was printed in this way looses it's validity directly after the workflow is finished. Moreover, if I understand https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#permissions-for-the-github_token correctly, the default permissions are only 'read'. So the attack surface is not terribly large, but I suggest the following to be on the safe side:

@fchapoton
Copy link
Contributor

what exactly needs to be done ?

@fchapoton
Copy link
Contributor

how to find all places in the logs with such compromised data ?

@dimpase
Copy link
Member

dimpase commented Mar 17, 2025

Is it this one:
GHSA-mrrh-fwg8-r2c3 ?

@dimpase
Copy link
Member

dimpase commented Mar 17, 2025

how to find all places in the logs with such compromised data ?

we don't need to. We need this to stop by this upgrade, but we can assume all sagemath org tokens are compromised

and on all the forks which run our Actions, if I am not mistaken

@dimpase
Copy link
Member

dimpase commented Mar 17, 2025

to be on a safe side, I just posted
on sage-devel, sage-support, sage-release:

https://groups.google.com/g/sage-release/c/QP60KVd4Af4/m/vuudv0MIAwAJ

this is to point out that SageMath is one of GitHub orgs affected by

"tj-actions changed-files through 45.0.7 allows remote attackers to
discover secrets by reading actions logs"
https://github.com/advisories/GHSA-mrrh-fwg8-r2c3

we are working to fix this in sagemath GitHub org repos
(sagemath/sage, etc)
https://github.com/sagemath/sage/pull/39722

However, if you enabled GitHub's Actions on your fork of any of
sagemath's repo, I assume our GitHub secrets might have gotten
compromised too.
So you'd need to disable Actions on your forks for the time being, and
change your secrets/tokens. 

@tobiasdiez
Copy link
Contributor

what exactly needs to be done ?

The compromised commit has been already removed upstream in the action, so at the moment no further secrets are posted in the github workflow. In particular, we don't need to upgrade this action urgently.

But as @dimpase said, we should assume that someone might have temporarily gained access to our github infrastructure and might have made changes to settings/pushed commits, and/or have changed secrets.

@eslerm
Copy link

eslerm commented Mar 17, 2025

The only secret my team found on sage was https://github.com/sagemath/sage/actions/runs/13866682283/job/38807100680#step:5:74

By now, that token should have expired. An attacker may have done something previously with that token. The GitHub action is no longer compromised. The action became malicious at March 14 2025 at 16:57:45 UTC with a commit, and was malicious for ~12 hours. The URL above is from a runner which was ran during that time.

edit: summary and recommendations by upstream tj-actions/changed-files tj-actions/changed-files#2463 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code p: critical / 2 s: positive review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants