Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard iframes #985

Closed
wants to merge 2 commits into from
Closed

Dashboard iframes #985

wants to merge 2 commits into from

Conversation

DiogoSoaress
Copy link
Member

What it solves

Resolves #974

How to test it

  1. Go to dashboard and observe safe apps iframes in the dashboard

Screenshots

Screenshot 2022-10-26 at 11 53 37

@github-actions
Copy link

github-actions bot commented Oct 26, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 26, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 725b470
Status: ✅  Deploy successful!
Preview URL: https://c1c1bb45.web-core.pages.dev
Branch Preview URL: https://dashboard-iframes.web-core.pages.dev

View logs

Comment on lines +11 to +23
export const appWidgets: WidgetType[] = [
{
appId: '1',
appUrl: 'https://swap.cow.fi/',
},
{
appId: '2',
appUrl: 'https://revoke.cash',
},
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a tag for you on staging: dashboard-mini-app
You can use that to query these instead of the ids.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Nice! Thanks

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@DiogoSoaress DiogoSoaress marked this pull request as ready for review November 10, 2022 09:37
@DiogoSoaress DiogoSoaress marked this pull request as draft November 10, 2022 09:47
@DiogoSoaress
Copy link
Member Author

Closing for #1149

@katspaugh katspaugh deleted the dashboard-iframes branch April 23, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants