Fix Powerline glyphs position and size in some cases #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] The Powerline glyphs can have strange width if a non-mono font is created. The width of the glyphs is then based on the symbol font which is not always useful. Some get a very slim advance width. [how] Temporarely turn on '--mono' handling of the glyphs if a Powerline codepoint is processed. Fixes: #1695 Signed-off-by: Fini Jastrow <[email protected]>
Finii
force-pushed
the
bugfix/Powerline-in-square-fonts
branch
from
0ccfab1
to
a539be0
Compare
[why] When we have a 'stubby' font, i.e. one with a square-ish cell the 'pa' scaled Powerline icons are just too big. Normally 'stubby' fonts prevent scaling into 2 cells - with 'xy' scaling. For the Powerline glyphs - which are fitted into the cells - we want to avoid scaling so big and the Powerline glyphs should keep a square or slimmer appearance. [how] Enforce the '1' scaling rule for powerline glyphs in 'stubby' fonts. Relocate some code to have this in the right spot before anything is done with the scale options. Signed-off-by: Fini Jastrow <[email protected]>
Finii
force-pushed
the
bugfix/Powerline-in-square-fonts
branch
from
a539be0
to
1210d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WILL BE FILLED LATER
Requirements / Checklist
Issue number where discussion took place: #xxx
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)