-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement focusable attribute for Window #4124
base: master
Are you sure you want to change the base?
Conversation
How keyboard input generally works with such windows or it doesn't and you have mostly pointer input? |
Yeah, they don't take keyboard focus, which is a feature - it allows you to interact with the overlay window without taking focus away from the current app. Imagine an on-screen keyboard, for example, we need to be able to click the keyboard buttons but have keyboard input still go to the app in the background. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macOS impl looks fine apart from the duplicated state. Requested changes because I'd like to see more docs, but am otherwise fine with the API.
@madsmtm rebased and addressed feedback, see last two commits in the force push |
32501c9
to
e294cf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks fine, only uncertain about is_focusable
return value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll leave this open for a week or so (please remind me if I forget) for the other maintainers to comment on X11 and Windows impls (I've reviewed them myself, but it's hard for me to know if they're semantically correct).
changelog
module if knowledge of this change could be valuable to usersif focusable is false, a window won't take focus, even if you interact with it
this is very useful for always-on-top floating utility windows