Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xdg instead of directories-next; correct typo in directory name #96

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

smoelius
Copy link
Contributor

@smoelius smoelius commented Mar 22, 2024

This PR has two commits:

EDIT: I could make these two PRs, or scrap either change, if you prefer.

@Shnatsel
Copy link
Member

The dependency change and typo fix look good. Why does this also rename a directory and update references to it?

@smoelius
Copy link
Contributor Author

Why does this also rename a directory and update references to it?

In #93, I created a directory named dep_tests. But that directory is referenced by tests in a module called deps, not dep. Hence, the directory should rightfully be called deps_tests, not dep_tests.

Sorry to be OCD, but it has irked me. And since I was submitting a PR anyway, I thought I would fix it.

@Shnatsel
Copy link
Member

I see. What is the typo fix? I cannot spot it in the diff.

@Shnatsel
Copy link
Member

Also, CI fails. Please run rustfmt to format the code. If that doesn't help please let me know - it's possible that CI version of rustfmt is too old.

@smoelius
Copy link
Contributor Author

I see. What is the typo fix? I cannot spot it in the diff.

Naming the directory dep_tests instead of deps_tests is what I am calling a "typo." The fix is to rename the directory to the latter. (Sorry for being unclear.)

@Shnatsel Shnatsel merged commit ede428b into rust-secure-code:master Mar 22, 2024
3 checks passed
@Shnatsel
Copy link
Member

Ah I see. Thanks! Merging.

@smoelius smoelius deleted the xdg branch March 22, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants