Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't pass -Crelocation-model=static to host targets #536

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

Freax13
Copy link
Member

@Freax13 Freax13 commented Feb 11, 2025

The bootloader integration tests recently started failing on Linux and Windows because of this. I think Rust probably ought to support this, but there's also no good reason for us to do this.

@Freax13 Freax13 force-pushed the fix/ci-static-relocation branch 3 times, most recently from 35000f4 to 980184c Compare February 11, 2025 21:48
If --target is set any flags from RUSTFLAGS only affect that target.
@Freax13 Freax13 force-pushed the fix/ci-static-relocation branch from 980184c to c47d970 Compare February 11, 2025 21:51
@Freax13 Freax13 marked this pull request as ready for review February 11, 2025 21:55
@Freax13 Freax13 requested review from phil-opp and josephlr February 11, 2025 21:55
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@phil-opp phil-opp merged commit f01a291 into rust-osdev:master Feb 12, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants