UEFI Allocator: Implement cores allocator_api
#1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
changed the title
cores allocator_api
phip1611
changed the title
cores allocator_apicores allocator_api
phip1611
force-pushed
the
uefi-alloc-api
branch
from
a1fca2f to
81b2d33
Compare
No need for this so far, but this provides downstream users more flexibility.
phip1611
force-pushed
the
uefi-alloc-api
branch
from
81b2d33 to
04e87f7
Compare
uefi/src/allocator.rs
Outdated
| #[cfg(feature = "unstable")] | ||
| unsafe impl core::alloc::Allocator for Allocator { | ||
| fn allocate(&self, layout: Layout) -> Result<NonNull<[u8]>, core::alloc::AllocError> { | ||
| let ptr = unsafe { <Allocator as GlobalAlloc>::alloc(self, layout) }; |
There was a problem hiding this comment.
Do we need to do something here to handle ZSTs? I'm not familiar with the details of the Allocator trait, but I noticed this in the documentation:
In contrast to
GlobalAlloc,Allocatorallows zero-sized allocations. If an underlying allocator does not support this (like jemalloc) or responds by returning a null pointer (such aslibc::malloc), this must be caught by the implementation.
There was a problem hiding this comment.
Yes, I'm just not sure how to handle it :D but I can figure it out, I guess
There was a problem hiding this comment.
Nice use case but you're right. I added it in a dedicated commit
We used std::alloc::System as template. [0] https://doc.rust-lang.org/src/std/alloc.rs.html#137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the allocator API (of
core) for the UEFI allocator.Checklist