uefi-raw: Fix ATA_PASS_THRU_PROTOCOL bindings #1619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an important fix! - The AtaPassThruCommandPacket was broken. - The AtaPassThruProtocol::pass_thru function signature had a redundant *mut - The field-name was horrible :D
phip1611
reviewed
Apr 10, 2025
phip1611
reviewed
Apr 10, 2025
phip1611
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an important fix for the raw bindings of
ATA_PASS_THRU_PROTOCOLAtaPassThruCommandPacketwas broken (missing fields).AtaPassThruProtocol::pass_thru()function signature had a redundant*muton theeventparameterThis was previously part of #1595
Blocks: #1595
Checklist