uefi: remove duplication in DevicePathHeader; use uefi-raw #1613
+427
−400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
dvcp
branch
2 times, most recently
from
6f640f4 to
11bfcc3
Compare
phip1611
force-pushed
the
dvcp
branch
3 times, most recently
from
39b76eb to
4fe30f3
Compare
nicholasbishop
approved these changes
Apr 15, 2025
| @@ -25,6 +25,9 @@ | |||
| `proto::device_path::text` to `proto::device_path`. | |||
| - **Breaking:** `exit_boot_services` now consumes a `Option<MemoryType>` which | |||
| defaults to the recommended value of `MemoryType::LOADER_DATA`. | |||
| - **Breaking:** Removed duplication in `DevicePathHeader`. This change however | |||
| doesn't affect many users. Instead of public fields, there are public | |||
There was a problem hiding this comment.
nit: I would take out "This change however doesn't affect many users." It's hard to predict how much code will be affected by a change, so better to stick with just what changed.
| /// Header that appears at the start of every [`DevicePathNode`]. | ||
| /// Fixed header that appears at the start of every [`DevicePathNode`]. | ||
| /// | ||
| /// This type is ABI-compatible. |
There was a problem hiding this comment.
Suggested change
| /// This type is ABI-compatible. | |
| /// This type is ABI-compatible with `EFI_DEVICE_PATH_PROTOCOL`. |
| self.0.sub_type | ||
| } | ||
|
|
||
| /// Returns the total length of the device path. |
There was a problem hiding this comment.
Suggested change
| /// Returns the total length of the device path. | |
| /// Returns the total length of the device path node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uefi: remove duplication in DevicePathHeader; use uefi-raw
Checklist