use threads instead of futures in build.rs #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no inherent reason why we should use future-based concurrency in build.rs. We don't spawn many futures and we don't make use of any of the nice patterns made possible by structured concurrency. The downside of using futures is that we have to pull in a bunch of dependencies. Switching to sync code and removing the dependencies resulted in a nice performance improvement (35s -> 30s). Also, it's just good practice to reduce the number of unneeded dependencies especially if some of them are unmaintained.
macos-12 has been removed from GitHub actions.
|
@phil-opp please remove the "Test (macos-12)" required check in the repository settings. The macos-12 platform no longer exists. I don't have access to these settings for this repo. |
|
Done! I also gave you full access to the repo now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no inherent reason why we should use future-based concurrency in build.rs. We don't spawn many futures and we don't make use of any of the nice structures made possible by structured concurrency. The downside of using futures is that we have to pull in a bunch of dependencies. Switching to sync code and removing the dependencies resulted in a nice performance improvement (35s -> 30s). Also, it's just good practice to reduce the number of unneeded dependencies especially if some of them are unmaintained.
Closes #483